IsStale flag is now reset properly

leapmotion / LeapMotionCoreAssets

Unity Assets for Leap Motion v2 Skeletal Tracking

Apache License 2.0

166 stars 81 forks source link

IsStale flag is now reset properly #160

Closed Amarcolina closed 8 years ago

Amarcolina commented 8 years ago

IsStale flag was never set to false, resulting in the eye texture data being recalculated every frame, resulting in lots of garbage and slowdown.

[ ] Verify with Unity profiler that with fix that OnPreRender no longer generates tons of garbage and is super slow.

@protodeep

Aranda commented 8 years ago

Hi, just FYI I had trouble downloading the Unity Core Assets from the Leap website. This page has a broken link: https://developer.leapmotion.com/documentation/orion/unity/index.html

I eventually found them here: https://developer.leapmotion.com/unity

Also, presumably it's a good idea to apply the fix in this pull request to the downloaded v4.0.0?. Would you recommend any other commits from this repo?

Thanks!

Amarcolina commented 8 years ago

You would want to use the branch feature-CoreAssets-V3, which contains all of the newest changes. Until this PR gets merged in you can also use the commit from it to help with efficiency as well.

protodeep commented 8 years ago

...and please note this was just merged into feature-CoreAsset-V3

Aranda commented 8 years ago

Thanks. Can someone let me know which commit is for v4.0.0? Maybe update the readme - it's useful to see what has gone in since the version available on the website.