search

leapmotion / autowiring

A C++ Inversion of Control Framework
http://autowiring.io/
Apache License 2.0
149 stars 17 forks source link

Restore <autowiring/signal.h> #1008

Closed jdonald closed 8 years ago

jdonald commented 8 years ago

While <signal.h> can be confusing as it shares its name with a standard UNIX header, it's explicit enough when customers #include <autowiring/signal.h>

We have good reason for calling it <autowiring/signal.h> as outlined in #851 when this was first added. Furthermore, I don't want to make a breaking change forcing us to autowiring-1.1.

The problem we had to work around in #998 is properly dealt with by not adding all the dangerous include paths.

hham commented 8 years ago

Build fails. It seems to be from travis setting. My local build is successful.

jdonald commented 8 years ago

I've pushed a new fix that seems to work for Travis's in-source build. Please try it out on your out-of-source build environment.

hham commented 8 years ago

Builds fine in my local machine and travis.