search

learn-anything / react-mindmap

React component for MindNode maps
https://learn-anything.xyz
MIT License
424 stars 108 forks source link

Example code seems to be failing #12

Closed jikkujose closed 7 years ago

jikkujose commented 7 years ago

The example seems to be failing with the error:

Uncaught ReferenceError: React is not defined

Uncomment the lines in App/index.js to replicate the issue in this repo: https://github.com/JikkuJose/react-lab

nglgzz commented 7 years ago

Try importing React via a CDN instead, that should fix it.

Also you can look at this repo to see how they're using react-mindmap.

jikkujose commented 7 years ago

Why is it built like that? Isn't it an anti pattern? Many others will be able to contribute when standards are followed.

nglgzz commented 7 years ago

I checked now and you're right, it was an unwanted behavior. It should be fixed in version 2.0.9.

I'm closing this issue, feel free to reopen it if the problem persists.