search

learn-awesome / learndb

Curated learning resources with topics, formats, difficulty levels, expert reviews and metadata tags
120 stars 21 forks source link

Dark mode is broken #42

Closed prince-ao closed 2 years ago

prince-ao commented 2 years ago

On the Firefox browser the main background is black and the nav & nav links are both white making the nav link words unreadable. This error does not happen on the chromium browser. Screenshot_20220613_142814

nileshtrivedi commented 2 years ago

Thanks for reporting. I can see the same issue in Chrome with the OS being in dark-mode.

nileshtrivedi commented 2 years ago

A good path here is to implement dark mode as dynamically applied theme. So, we should avoid using Tailwind's dark: classes inside the markup.

nileshtrivedi commented 2 years ago

Fixed this by disabling dark mode. I'd prefer to implement dark mode as a theme, and to use themes, I think we should rethink what it means to have a color palette.