Add remove_404.js - Githubissues

learn-awesome / learndb

Curated learning resources with topics, formats, difficulty levels, expert reviews and metadata tags

123 stars 22 forks source link

Add remove_404.js #69

Closed milandeepak closed 1 year ago

milandeepak commented 1 year ago

In a new folder called "scripts," I've created a new file, remove404.js, which checks the links in db/items.json and deletes any that return 404 errors—only when link array is not empty will this process occur

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
learndb	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 5, 2023 at 9:45AM (UTC)

nileshtrivedi commented 1 year ago

Looks good. Thanks @milandeepak

A few comments:

Instead of db/hello.json it should work with db/items.json.
After remiving the link, an item may become one with 0 links which would be invalid. Which means that either the item itself should be deleted or more simply, don't delete a 404 link if it's the only link for an item.

milandeepak commented 1 year ago

Oh sorry, for that mistake , I will correct it soon.