search

learn-co-curriculum / basic-apis-lab

Other
0 stars 1 forks source link

Not pressing: API ID and secret not needed #3

Open onyoo opened 8 years ago

onyoo commented 8 years ago

This lab 100% works without authentication. I generated but never used, and passed all tests, and could make requests from browser. This section of the doc explains why:

Rate limit

The Search API has a custom rate limit. For requests using Basic Authentication, OAuth, or client ID and secret, you can make up to 30 requests per minute. For unauthenticated requests, the rate limit allows you to make up to 10 requests per minute.

https://developer.github.com/v3/search/#rate-limit

Could simplify lab.

AnnJohn commented 8 years ago

thanks @onyoo for feedback. we should be able to get to this soon now!