III.ii.02 oo-vehicle - Githubissues

learn-co-curriculum / mobile-development-curriculum

Other

0 stars 0 forks source link

III.ii.02 oo-vehicle #36

Closed markedwardmurray closed 9 years ago

markedwardmurray commented 9 years ago

Update for objectives and parallel style.

Let's not explain the instructions twice: incorporate "recap" section into the instructions.

They know how to create an array by now.

There might be a little too much hand-holding with all these hints at the end.

Check NSInteger / NSNumber in tests: https://github.com/learn-co-curriculum/OO-Vehicle/issues/7

AnnJohn commented 9 years ago

Iceboxing for now and Mark will close when he's done with the issue

markedwardmurray commented 9 years ago

i like the concept of this lab, FISVehicle, FISPlane i think work fine, though I'd rename some of the properties and rewrite the test descriptions.

FISCar currently adds not functionality from FISVehicle so it's pointless. Need at car-specific attributes to the model. FISRaceCar should inherit from FISCar instead of FISVehicle directly, showing the inheritance chain of customization down more than just a single level.

tests can be rewritten to remove redundancies and improve style

tomalley104 commented 9 years ago

bullet points from 9/24 meeting with Mark and Ann

scrap “examples” and “hints” sections
make FISRaceCar actually useful (subclass FISCar to show how you can continue the chain)
work in overriding superclass methods if possible
refactor tests (too redundant)