learn-co-curriculum / mobile-development-curriculum

Other
0 stars 0 forks source link

III.ii.09 lab-ios-objc-blackjack #43

Closed markedwardmurray closed 9 years ago

markedwardmurray commented 9 years ago

Improve clarity of instructions, edit for parallel style.

Point out that setHand: should recalculate the handscore.

Warn that _ivar should not be used outside initializers and setters/getters.

AnnJohn commented 9 years ago

Iceboxing for now and Mark will close when he's done with the issue

markedwardmurray commented 9 years ago

don't use description, same as OOP-Cards-Model convert NSNumber properties to primitives

we should provide the logic for scoring the hand, there are always a few students who have never played Blackjack before

should not rely on overriding a setter/getter (removing from curriculum). Rewrite the tests and instructions to NOT depend on this logical structure.

tests that detect method calls are redundant. the build will fail if the specified methods are absent

problem paradigm: the drawing a card should pull the first card. to randomize this, a different method called shuffleDeck should be written and called upon each new game. when playing blackjack, you don't deal from a random place in the middle of the deck, you randomize all of the cards and then deal from the top. The implementation should match the problem.

remove code from AppDelegate: boilerplate and manual test code inside application:didFinishLaunchingWithOptions:

markedwardmurray commented 9 years ago

https://github.com/learn-co-curriculum/objc-BlackJack

markedwardmurray commented 9 years ago

convert from NSNumber

don't use ivars

remove validation stuff

see what Tom makes of OOP-Cards-Model

markedwardmurray commented 9 years ago

resolved by https://github.com/learn-co-curriculum/objc-BlackJack/pull/7