learn-co-curriculum / omniauth_lab

Other
1 stars 349 forks source link

Mistake in Readme instructions for registering an OAuth app on Github #18

Open Sdcrouse opened 4 years ago

Sdcrouse commented 4 years ago

In the Readme's instructions for registering a new OAuth application on Github, they have us fill out the form like this:

image

There are a couple of problems with this. First, if you try naming the application GistLister, Github's form will show this error: "Name should not begin with Github or Gist". The other problem is that the "Authorization callback URL" is incorrect. We defined the callback route to look like this:

match '/auth/:provider/callback', to: 'sessions#create', via: [:get, :post]

The Authorization Callback URL should therefore be http://localhost:3000/auth/github/callback, not http://localhost:3000/app/github/callback.

Thanks for looking into this!

--- Sdcrouse