search

learn-co-curriculum / oo-student-scraper

Other
2 stars 316 forks source link

Make test to check for use of OpenURI? #50

Closed gj closed 6 years ago

gj commented 8 years ago

To match the README's demand for OpenURI, there should probably be a test that checks whether self.scrape_index_page and self.scrape_profile_page use OpenURI. Currently, it's possible to avoid using OpenURI:

def self.scrape_index_page(index_url)
    html = File.read(index_url)
    Nokogiri::HTML(html)...
pletcher commented 8 years ago

Thanks for being a part of the Learn community!

Keep in mind that this space is for specific issues related to the content of this lesson.

If you're reporting on the content of this lesson, it'd be super helpful if you could include a stack trace of any errors that you're seeing.

If you'd like to report a bug about the Learn IDE, the Ask a Question form, opening a file, or the lights not working on Learn, please report a bug directly on https://learn.co. (You can find the bug report form by clicking on your avatar in the upper right, and then selecting "Report A Bug".)

We want to respond as quickly as possible and be as helpful as possible, so please be sure to include steps to reproduce the issue (as best you can remember) and any pertinent details about your environment. (Are you using the Learn IDE? Coding from the ISS?) We'll figure out what's up and get back to you ASAP.