search

learn-co-curriculum / oo-student-scraper

Other
2 stars 316 forks source link

Typo in #initialize method paragraph...word achieve #72

Closed ccklight closed 5 years ago

ccklight commented 5 years ago

Correct spelling is achieve (see below). The #initialize method should take in an argument of a hash and use metaprogramming to assign the newly created student attributes and values in accordance with the key/value pairs of the hash. Use the #send method to acheive this.

sgharms commented 5 years ago

Thanks! Fixed!

ccklight commented 5 years ago

Hi Steven,

Are my contributions - “raise an issue” kept in my github profile? ? I do not see it in files.

I’m only 35% in my curriculum so I can only address minor typos. FI is excellent so there are no code problems ( and if there were I wouldn’t be able yet to detect them in rspec etc).

Still, I want to continue showing my track record of activity, participation in my community, and teamwork in my github. If it’s not in Github, how can I do this ?

Thanks for your response.

On Sun, Nov 4, 2018 at 4:17 AM Steven G. Harms notifications@github.com wrote:

Thanks! Fixed!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/learn-co-curriculum/oo-student-scraper/issues/72#issuecomment-435657417, or mute the thread https://github.com/notifications/unsubscribe-auth/AlBIyUCE_youcRo9_RIpJQDz3DbbzkvMks5urr62gaJpZM4YMaSD .

sgharms commented 5 years ago

Issue activity is recorded in the activity feed (butI don't think that affects the green square mosaic). You could check with GitHub on that one ;)

But I see:

image

Which documents your contribution. Also, a list of these is likely surfaced through the GitHub API. You could use the octokit gem and your new programming skills to poll that :)