search

learn-co-curriculum / oo-student-scraper

Other
2 stars 316 forks source link

Create From Collection Issue #73

Closed helloamandamurphy closed 5 years ago

helloamandamurphy commented 5 years ago

Hey, so in the spec for the create_from_collection method in the Student class, it says the method will use the Scraper class: .create_from_collection uses the Scraper class to create new students with the correct name and location.

But the solution does not use the Scraper class at all. def self.create_from_collection(students_array) students_array.each do |student_hash| Student.new(student_hash) end end

sgharms commented 5 years ago

@helloamandamurphy Thanks for this insight. Really, these tests shouldn't have mentioned Scraper at all. We've corrected that and done some version updates.