learn-co-curriculum / oo-tic-tac-toe

Other
4 stars 641 forks source link

Added single permutation check #16

Closed bhollan closed 8 years ago

bhollan commented 8 years ago

Added an /or/ permutation check in the WIN_COMBINATION test.

Also changed a few 'position's to 'index'.

mendelB commented 8 years ago

@bhollan Thanks for yet another great submission ;) The WIN_COMBO stuff was useful and we implemented a similar fix for that problem 👍 We're holding off on changing the position stuff to index as we figure out the right consistent approach for all the Tic-Tac-Toe labs. I'm gonna close this. Thanks again!!