search

learn-co-curriculum / oo-tic-tac-toe

Other
4 stars 641 forks source link

Fix a bunch of issues #20

Closed mendelB closed 8 years ago

mendelB commented 8 years ago

The commits reflect the various issue being closed by each change but roughly:

  1. Change the spec for WIN_COMBINATIONS to allow the combos in different orders fixes #18 fixes #11
  2. Add instruction to use previous methods from previous labs fixes #4
  3. Add test to check that user is calling display_board in the turn method fixes #19
  4. Change the instructions for the turn method so that the display_board method is called only when the move is valid, as opposed to the way it is now - where it would get displayed for as many wrong moves the user inputted.

I think that just about covers it 😃 @PeterBell @AnnJohn

mendelB commented 8 years ago

And I'm not sure why this Linter test is failing, I didn't touch the bash snippet and it's on the list of valid snippet command?

PeterBell commented 8 years ago

LGTM! 👍

PeterBell commented 8 years ago

It's fine - merged it in

PeterBell commented 8 years ago

We weren't making anything worse . . .