learn-co-curriculum / oo-tic-tac-toe

Other
4 stars 641 forks source link

match #position_taken? tests to README behavior #32

Closed kjleitz closed 7 years ago

kjleitz commented 8 years ago

Fixes https://github.com/learn-co-curriculum/oo-tic-tac-toe/issues/27

...but the implementation in each of the mentioned methods is still different from the previous TTT labs, which is confusing. It should be made obvious that these methods should take user input (1-9, as opposed to a plain index, 0-8) since the previous ones take a plain index.

gj commented 7 years ago

Fixed in #33. Thanks @kjleitz !