search

learn-co-curriculum / playlister-cli

Other
0 stars 3 forks source link

Issues with Test Suite #7

Closed aviflombaum closed 9 years ago

aviflombaum commented 9 years ago

The tests for the LibraryParser really confused... am I crazy or are the tests expecting slightly different behavior than the CLI class?

Eventually managed to get the test to pass, but still don't really understand what the "call" method is there for, or why "self.parse" should exist?

Also seems weird that the CLI expects the parse method to take a filepath as an argument, but the tests do not. Wound up setting a default argument of "db/data" which felt kinda arbitrary.

jmburges commented 9 years ago

@aviflombaum in the future can you tag these? I'm writing a wiki page on raising issues, so it should be more straight forward in the future.

aviflombaum commented 9 years ago

Ya, will do, I didn't know what Labels we were using.

jmburges commented 9 years ago

I figured. Pretty much if it's test related, use the test labels. If it also requires a code change tag on the code label

AnnJohn commented 9 years ago

Iceboxing the issue