learn-co-curriculum / playlister-sinatra

Other
0 stars 387 forks source link

Depracation of RSpec configuration #50

Closed genericlady closed 8 years ago

genericlady commented 8 years ago

ruby 2.3.0

Debug

Deprecation Warnings:

RSpec::Core::Configuration#treat_symbols_as_metadata_keys_with_true_values= is deprecated, it is now set to true as default and setting it to false has no effect.

If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

1 deprecation warning total

Solution

# ./spec/spec_helper.rb:15
RSpec.configure do |config|
  # config.treat_symbols_as_metadata_keys_with_true_values = true
  config.run_all_when_everything_filtered = true
  config.filter_run :focus
  config.include Rack::Test::Methods
  config.include Capybara::DSL
  DatabaseCleaner.strategy = :truncation

submitted pull request. do I just clone it and make changes to spec then push it back after pull request is approved?

AnnJohn commented 8 years ago

for web 0416