learn-co-curriculum / python-p3-oop-putting-it-all-together

Other
1 stars 2.71k forks source link

instructions #10

Open katbruce opened 1 year ago

katbruce commented 1 year ago

Canvas Link

https://learning.flatironschool.com/courses/6329/assignments/239706?module_item_id=563645

Concern

line 74 and 80: the pytest should either be changed to lib/testing/book_test.py (same for shoe_test) or specify to navigate into lib before running in command line

Additional Context

No response

Suggested Changes

the pytest should either be changed to lib/testing/book_test.py (same for shoe_test) or specify to navigate into lib before running in command line

professor-ben commented 1 year ago

Hi Kat,

We were just doing some work in this repo the other day- would you mind elaborating a little more on what's happening? Is pytest not executing from root?

Thanks, Ben

katbruce commented 1 year ago

It wasn’t testing anything from root with just pytest

On Wed, May 10, 2023 at 9:53 AM professor-ben @.***> wrote:

Hi Kat,

We were just doing some work in this repo the other day- would you mind elaborating a little more on what's happening? Is pytest not executing from root?

Thanks, Ben

— Reply to this email directly, view it on GitHub https://github.com/learn-co-curriculum/python-p3-oop-putting-it-all-together/issues/10#issuecomment-1542441948, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3DSKJQXILMSMEIMXGJTQQLXFO2XNANCNFSM6AAAAAAXUV25WA . You are receiving this because you authored the thread.Message ID: <learn-co-curriculum/python-p3-oop-putting-it-all-together/issues/10/1542441948 @github.com>

professor-ben commented 1 year ago

That's interesting- pytest.ini should be preventing that. We made some changes a couple of days ago, would you mind cloning this down, entering your Pipenv, and seeing if you can run test from root now?

Thanks, Ben