learn-co-curriculum / react-hooks-props-destructuring

Other
4 stars 2.78k forks source link

Saying we "assign keys" seems misleading (as compared to assigning their associated values) #2

Closed brigj1 closed 2 years ago

brigj1 commented 2 years ago

Canvas Link

https://learning.flatironschool.com/courses/5186/assignments/180048?module_item_id=397466

Concern

in this phrase: Destructuring allows us to take the keys from the props object and assign them to variables with the same names.

we say we assign keys to variables.

Well, we are assigning the associated values of the keys. Ack!, "Associated values" is a complicated phrase, but still, maybe we can use "values" language in describing the assignment?

Additional Context

No response

Suggested Changes

maybe change this: Destructuring allows us to take the keys from the props object and assign them to variables with the same names.

to this?: Destructuring allows us to take the keys from the props object and assign their values to variables with the same names.

"Associated values" might be more accurate but seems more technical than necessary: Destructuring allows us to take the keys from the props object and assign their associated values to variables with the same names.