learn-co-curriculum / swift-inheritance-basics

Other
0 stars 0 forks source link

NSObject #2

Open JimCampagno opened 7 years ago

JimCampagno commented 7 years ago

Hmm. I'm not sure how I feel about this reading. The prior reading would have been their first exposure to classes. This seems to bring up NSObject VERY early. I would argue that we shouldn't bring up NSObject at all. It also brings up protocol conformance (or showing them protocol conformance) very early. They don't even know what the word protocol means. I think we need a separate reading on inheritance.

This reading isn't in the online course--only being offered to the immersive course right now.

I'm tagging you Ian, only because I see you have a commit on it. Really... no other reason, anyone who wants to tackle this should fix it up (including me!).

@ianrahman

markedwardmurray commented 7 years ago

All valid criticisms. This was originally voiced towards the iOS-0915 class in their 11th week, so proficiency in Objective-C OOP inheritance and knowledge of protocols was assumed. In practice, I have yet to create a Swift class that inherits from NSObject. It would also be good to include a section on failable initializers in the rewrite.