Not all tests being run

[marcelgalang]

@lekan20 had the following issue

• only 79 learn or rpsec test being run out of the 106 tests. I cloned and ran rspec and found not all tests were running on his master branch and all ran on the solution branch.

[BrennanFulmer]

To expand on the problem, test 79 in 010_music_library_controller_spec.rb is for #call. The issue appears to be caused the #call test inputting "exit", which is supposed to exit the user input loop but appears to exit the whole test run. This means students who don't manually run the last few rspec tests end up being able to skip about 20% of the work that needs to be done (based on above it sounds like running them locally is another workaround). I have attached a screenshot of this happening.

[BrennanFulmer]

Upon further testing I found that this problem only occurs when the Call method of the MusicLibraryController doesn't properly end when the user enters "exit". Again to guess as to the problem, mistaken user input handling may be stalling the tests in an infinite loop that Rspec times out of. The fix might be checking for the presence of the string exit within the method prior to testing actually inputting exit, or if possible go a step further and look for logic comparing a variable to "exit".

[lekan20]

Hey!

Thank you for this update!

Best, Lekan

On Fri, Jun 1, 2018 at 10:11 PM, Brennan Fulmer notifications@github.com wrote:

Upon further testing I found that this problem only occurs when the Call method of the MusicLibraryController doesn't properly end when the user enters "exit". Again to guess as to the problem, mistaken user input handling may be stalling the tests in an infinite loop that Rspec times out of. The fix might be checking for the presence of the string exit within the method prior to testing actually inputting exit, or if possible go a step further and look for logic comparing a variable to "exit".

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/learn-co-students/ruby-music-library-cli-v-000/issues/902#issuecomment-394049357, or mute the thread https://github.com/notifications/unsubscribe-auth/AaW7hMPPWs1emLcJ7h_03nojmfhAsYhBks5t4fRagaJpZM4RdDkd .