search

learn-co / learn-test

⚠️ This gem is no longer maintained & its web features are no longer available
MIT License
3 stars 29 forks source link

Check for dependencies to determine whether to run npm install #29

Closed pletcher closed 8 years ago

pletcher commented 8 years ago

Fixes #28

npm install is not foolproof, and the existence of a node_modules directory isn't proof that all dependencies have been installed. This change makes sure that any dependencies listed in a package.json are included in node_modules before running the mocha strategy.

loganhasson commented 8 years ago

@pletcher bah, not sure how i missed this! would you mind rebasing? definitely wanna get this in. and thanks!!

pletcher commented 8 years ago

@loganhasson no worries -- I bumped the version to 2.4.1 as well -- should be right, right? Patch? Or minor version? (Semver, gah.)

loganhasson commented 8 years ago

@pletcher thanks! and yeah, version seems fair to me