search

learn-co / learn-test

⚠️ This gem is no longer maintained & its web features are no longer available
MIT License
3 stars 29 forks source link

Pytest strategy added to learn-test gem. Tested with a mixture of pas… #53

Closed DanielSeehausen closed 5 years ago

DanielSeehausen commented 6 years ago

…sing/failing/skipping/mixed pytest labs

DanielSeehausen commented 6 years ago

@gj this gem is the boonies of our code base and because you were last on it a year ago i assigned you as reviewer. If you wouldn't mind taking a peak at the js_strategy and mocha_spec.rb i'd certainly appreciate it. Nothing new -- just altered tests and broke out one helper method while doing so.

@StevenNunez not sure where we stand on deprecating unittest, but currently I commented out matching for the strategy and the files themselves. We got the official "we are deprecating it from curriculum", so wasn't sure how best to proceed with it in our code base. Another reason for commenting is that it parses some of the same test file patterns as pytest.

DanielSeehausen commented 6 years ago

@gj review requests have all been addressed! most recently, unittest files were removed and that class-instance jank has been simplified.