search

learn-co / learn-test

⚠️ This gem is no longer maintained & its web features are no longer available
MIT License
3 stars 29 forks source link

Add rspec example flag #58

Closed AspenJames closed 5 years ago

AspenJames commented 5 years ago

Add support for using RSpec's --example flag @aviflombaum

Staff

AspenJames commented 5 years ago

Requested changes made - thanks for catching that @aviflombaum!

aviflombaum commented 5 years ago

@meryldakin @gj as you have open work on this gem, are you good merging this as you resolve your PR for jest and cut a new learn-test gem and learn gem? Not sure what our version release plans are but I reviewed @AspenJames code here and it's good, seems unlikely to cause any issues and is tested.

meryldakin commented 5 years ago

yep sounds good @aviflombaum!

AspenJames commented 5 years ago

@gj can I get an update on the status of this?

gj commented 5 years ago

Hi @AspenJames,

I don't know what the status of #57 is; perhaps @meryldakin knows. I'm happy to ship this PR the next time I need to update the gem, but I'm pretty slammed with other things at the moment.

aviflombaum commented 5 years ago

I re-reviewed and test this and am comfortable merging this - haven't checked #57 but that's def more complex, but this I would be down to merge. If @meryldakin and @gj agree, let's just merge and well plan a new cut of the gem soon but at least get this code in there?

gj commented 5 years ago

@aviflombaum sure, it's a harmless change even if the next person to cut a release of the gem doesn't realize this new code has been merged in.

AspenJames commented 5 years ago

Thanks all!