search

learn-video / mosaic-video

Generate mosaics from video inputs
Apache License 2.0
35 stars 6 forks source link

Feat/multiples inputs #11

Closed luiscovelo closed 9 months ago

luiscovelo commented 9 months ago

Hi, @mauricioabreu.

I fix the command builder to mount dynamic video inputs;

I created a manifest handler to serve a hls player a custom result containing all mosaics from tasks.json;

I update hls player to show buttons options reference each mosaic;

See this video with hls player updated: HLS player working.

Best reguards.

mauricioabreu commented 9 months ago

Could you split this PR into differents features/fixes? (not sure if that manifest change makes sense)

luiscovelo commented 9 months ago

Could you split this PR into differents features/fixes? (not sure if that manifest change makes sense)

Of course, i'll split this changes in another branchs to make easy a maintainability.

Related to manifest change, we can to discuss another ways to make this.

mauricioabreu commented 9 months ago

@luiscovelo given the last PRs, how many changes in this PR will be kept? Do we still need this PR?

Thank you for your contributions!

luiscovelo commented 9 months ago

@luiscovelo given the last PRs, how many changes in this PR will be kept? Do we still need this PR?

Thank you for your contributions!

@mauricioabreu,

We don't need kept this PR, because i split into new PR's merged in branch main.

Related about manifest endpoint, with theses new changes applied into main, i can to create a new handler to return a custom object for HLS player, containing all mosaics playlist, based in tasks.json, like this: 

[
    {
        "name": "mosaic",
        "playlist_url": "http://localhost:8090/playlist/playlist-mosaic.m3u8"
    },
    {
        "name": "mosaic2",
        "playlist_url": "http://localhost:8090/playlist/playlist-mosaic2.m3u8"
    }
]

And to mount a button for each mosaic returned.

Like this:

image

I guess creating this new endpoint makes it dynamic for HLS player.

What do you think?

mauricioabreu commented 9 months ago

It looks like a good idea. Would this feature be useful just for testing, right?

luiscovelo commented 9 months ago

@mauricioabreu,

I had thinking as a feature in case the user to have more than one mosaic registered.

How do you think to do so that the user can switch their mosaics for viewing?

mauricioabreu commented 9 months ago

@luiscovelo well, if someone/company is going to use this project, they will integrate in their own players. This is why I think the player component acts like a testing component

luiscovelo commented 9 months ago

@mauricioabreu,

Of course, you are right, don't make a sense implement this endpoint, for testing, one mosaic entry will be enough.