learning-rust / learning-rust.github.io

Rust Programming Language Tutorials for Everyone!
https://learning-rust.github.io
MIT License
1.48k stars 165 forks source link

Consider rewording of comparable language reference for interface trait comparison #3

Closed softprops closed 6 years ago

softprops commented 6 years ago

Referencing Java interfaces as a comparison to traits then right after making a "but" traits can have default method impls may cause some confusion for Java developers https://github.com/learning-rust/site/blob/master/source/docs/b5.impls_and_traits.md

The reason being that Java interfaces can also have default method impls https://docs.oracle.com/javase/tutorial/java/IandI/defaultmethods.html.

I'm suggesting the change because I'm offering this content up to my company of mostly Java/Scala developers as onboarding material for learning rust.

dumindu commented 6 years ago

acknowledged! Let me check on this weekend. Thanks

softprops commented 6 years ago

Awesome. There are some other areas I though could use some small improvement s. Are you open to pull requests?

dumindu commented 6 years ago

Hi,

Are you open to pull requests?

Yes, as long as you can keep the simplicity of the docs. And please make sure to write things on simplest and shortest way. Also try to target whole audience especially newcomers to programming.

Thanks

dumindu commented 6 years ago

I made a small change on Impls & Traits. @softprops can you check it?

Also feel free to create PRs and please let me know if you got any feedback from your developers how I can improve this doc further. Thanks

softprops commented 6 years ago

That works. One grammatical note

Multiple traits can be implemented to a single type.

Should probably read

Multiple traits can be implemented for a single type.

dumindu commented 6 years ago

Updated! Thanks