search

learning-rust / learning-rust.github.io

Rust Programming Language Tutorials for Everyone!
https://learning-rust.github.io
MIT License
1.48k stars 165 forks source link

Site CSS makes it less usable on ultrawide monitors #62

Closed EthanStandel closed 1 year ago

EthanStandel commented 1 year ago

Hey, great resource you have here! But there's some weird stuff done in the CSS that makes things go absolutely goofy on ultrawide monitors.

It looks like the developer tested the styles for ultrawide monitors like this.

image

And that seems fine, but when that's actually on my monitor, it looks like this.

image

The font size that is in my URL bar, or in the dev tools, or on the tab are perfectly optimal for reading.

I actually have to shrink the screen to make it readable, like this.

image

It looks like the problem is this file. Removing that and the reference here would fix the problem. I really think that users can be trusted to adjust their scaling to what's comfortable to them.

EthanStandel commented 1 year ago

Correction, Github sent me the wrong way due to it not getting along with Git submodule.

So I guess the fix actually needs to be implemented in the docura/docura repo. However, I'll leave this here because once that is fixed, this submodule hash will need to be updated... I think.

dumindu commented 1 year ago

Refer https://github.com/docura/docura/issues/1#issuecomment-1281148608 Fixed in https://github.com/docura/docura/issues/1