search

learning-software-engineering / learning-software-engineering.github.io

MIT License
16 stars 206 forks source link

Create logging_to_mysql.md #535

Closed hantien2002 closed 3 months ago

hantien2002 commented 3 months ago

From issue #470

Tahasp commented 3 months ago

Hey, would you be up to reviewing each other’s work?

hantien2002 commented 3 months ago

@Tahasp Hi, sorry I have already found teammate to review my work.

OliviaYZhou commented 3 months ago

Hi Tien, the PR looks good overall, I like the visuals and images you included, especially the video. One thing you could add is you can explain your logs table in Step 2. For instance, the user might not know what a level is or why it needs to be added. You have a pretty good explanation for users table in part 3, maybe you can do something similar for logs table. On a similar note, since you are adding a users table, but not all logging requires a user, you can add a section explaining a use case where someone would need a users table, and explain that this tutorial will be most helpful in similar cases.

hantien2002 commented 3 months ago

@OliviaYZhou Hi Olivia, thank you for your review and I have made changes based on your suggestion.

OliviaYZhou commented 3 months ago

Hi Tien, I've seen the changes and they look great. The explanations make the tutorial clearer. This will be a great guide for anyone who wants to create logging using mysql.