search

learning-unlimited / ESP-Website

A website to help manage the logistics of large, short-term educational programs
84 stars 57 forks source link

Class Changes lottery doesn't remove people from mailman lists. #1271

Open shulinye opened 10 years ago

shulinye commented 10 years ago

@benjaminjkraft (because you were working on mailman yes?)

HSSP's class change lottery didn't remove people properly from the mailman lists (well, suspected - there were 65 email addresses for a class of 59...)

jmoldow commented 10 years ago

https://github.com/learning-unlimited/ESP-Website/blob/main/esp/esp/program/controllers/classchange.py#L452

The lottery calls preregister_student() and unpreregister_student() to enroll and un-enroll students, respectively. This is because those functions are supposed to correctly updated Mailman subscriptions. If students were not removed from Mailman lists, it must mean that unpreregister_student() is not doing the correct thing.

This is done at https://github.com/learning-unlimited/ESP-Website/blob/main/esp/esp/program/models/class_.py#L1198

The code looks like it is removing students from A1234-students@ and A1234s1-students@, but not from other lists, for example A1234-class@. This could be the problem. Related to #686.

If that's not the problem, then that code must be incorrect somehow.

benjaminjkraft commented 10 years ago

I was working on mailman updates for deactivated users. This is another, independent mailman issue. I can work on it, but it's probably not going to happen in the next month, especially since it likely won't be relevant until the spring at least. The thing @jmoldow suggested is probably a good quick fix; the real solution is #1260.

lenaqr commented 10 years ago

Do we know whether the original bug was with -students or -class?

shulinye commented 10 years ago

-students

Shulin Ye

On Sat, Jul 19, 2014 at 4:25 AM, Anthony Lu notifications@github.com wrote:

Do we know whether the original bug was with -students or -class?

— Reply to this email directly or view it on GitHub https://github.com/learning-unlimited/ESP-Website/issues/1271#issuecomment-49503170 .

lenaqr commented 10 years ago

So, not what jmoldow said.

shulinye commented 10 years ago

Can't remember if it was a s1-students or a -students, but one of those.

Shulin Ye

On Sat, Jul 19, 2014 at 4:49 AM, Anthony Lu notifications@github.com wrote:

So, not what jmoldow said.

— Reply to this email directly or view it on GitHub https://github.com/learning-unlimited/ESP-Website/issues/1271#issuecomment-49503627 .