search

learning-unlimited / ESP-Website

A website to help manage the logistics of large, short-term educational programs
84 stars 57 forks source link

Template Issue on customforms index page #257

Closed jmoldow closed 12 years ago

jmoldow commented 12 years ago

When at /customforms/, the admin toolbar overflows its usual box and covers most of the page. If you use a CSS console to hide it, one can also notice that the usual fonts are different. The admin toolbar issue is noticeable on MIT's (esp.mit.edu/customforms/) and Stanford's (stanfordesp.org/customforms/) templates, but not on the default template (which doesn't have an admin toolbar). The font issue is noticeable on all templates, including the default (see dev2.learningu.org/customforms/).

The font issue is also noticable on pages which use a customform (see, for example, esp.mit.edu/teach/Splash/2012/quiz).

jmoldow commented 12 years ago

The admin toolbar issue is probably an error in the HTML or CSS code that defines it, I'm assuming, rather than an issue with customforms itself. But it might be due to customforms.

jmoldow commented 12 years ago

This should be looked into and fixed before tonight's release, since we want to encourage sites to start using customforms.

pricem commented 12 years ago

It's easy to fix the problem with the admin box covering the page - that was just a CSS name collision. One of the "bootstrap" stylesheets inclued by the page is overriding some of the other formatting (e.g. fonts) also; looking into that now.

pricem commented 12 years ago

My commits were a little spastic, but hopefully this is taken care of... does the latest code (with copying of default_styles to styles) look alright?

pricem commented 12 years ago

Closing this, since I think it's fine (and upon inspection of the MIT site, Jordan agreed).