search

learning-unlimited / ESP-Website

A website to help manage the logistics of large, short-term educational programs
82 stars 57 forks source link

Copy over choosable=2 modules from template programs #3640

Closed willgearty closed 1 year ago

willgearty commented 1 year ago

This copies over any modules from a template program that are "choosable=2" (i.e., manually enabled). This makes it so we aren't encouraging the use of these modules, but we are copying them over in case chapters have decided to use them.

While I was at it, I also cleaned up the new program form with a pretty blue box with information about all of these seemingly random things we copy over from template programs.

Fixes https://github.com/learning-unlimited/ESP-Website/issues/3573.

willgearty commented 1 year ago

OK, I've gone with a new approach that modifies the newprogram/program settings javascript to keep any custom modules. Now, instead of only enabling the modules that are included via the selected questions, it is the act of checking/unchecking questions that enables/disables only those specific modules. This means that these custom modules should now be shown on the "double check everything" page.

This also fixes a bug where the "charge for items" checkbox wouldn't uncheck if your program had an admission fee.

willgearty commented 1 year ago

I'm also adding a small change to the financial aid module which makes it hidden if there are no costs to cover. I could have made a separate PR, but it's such a small change and somewhat related to the changes already implemented here. Fixes https://github.com/learning-unlimited/ESP-Website/issues/3641.