search

learning-unlimited / ESP-Website

A website to help manage the logistics of large, short-term educational programs
82 stars 57 forks source link

Legend for ajax scheduler #3644

Closed willgearty closed 1 year ago

willgearty commented 1 year ago

This adds a popup legend to the ajax scheduler. We no longer do any sort of text styling, so this only is a legend for the cell background and border colors.

While I was at it, I also fixed various bugs related to moderator assignment and scheduling classes with moderators.

image

Fixes https://github.com/learning-unlimited/ESP-Website/issues/466. Fixes #461.

willgearty commented 1 year ago

Thanks for the suggestions @kkbrum! I've implemented the first two so far (plus a fix to actually use the contiguous tolerance tag).

For the third one, I tested this on my dev server and it appears to work as you would like it to. When a moderator is not available for part of a class, the whole class is greyed out. When a moderator is already moderating for part of a class, that part is yellow and the other part is green with grey slashes.

For the fourth one, I'm not sure we want to unassign moderators, but I agree that the "remaining slots" column is misleading as currently designed (mostly because we designed this whole implementation around doing moderator assignments after class scheduling and never thought about rescheduling classes after that). I could look into fixing this to account for unscheduled sections that moderators are assigned to? We would need to roughly estimate how many slots the unscheduled sections would require to be scheduled. This could possibly be its own PR, but probably not absolutely necessary.

For the last one, while I agree this would be great, this would take a LOT of work to implement, as we combine all of the teacher and moderator availabilities before we then change the colors of the sections. I would argue this would be a whole separate PR.