Make fruitsalad juicier.

learning-unlimited / ESP-Website

A website to help manage the logistics of large, short-term educational programs

82 stars 57 forks source link

Make fruitsalad juicier. #3704

Open pteromys opened 6 months ago

pteromys commented 6 months ago

https://github.com/learning-unlimited/ESP-Website/assets/380280/83a47a1f-8121-4d13-8634-6d4a62ec2f04

Add a small hover effect to the left-side tabs. While we're at it, fix the accent stripe size to accommodate custom rounding_radius. (No sites currently seem to customize it but maybe this'll make it easier.)
Additionally, enable audio feedback if the user types in one of a few famous cheat codes.

Prior art: https://www.janneysound.com/project/soundstair-musical-stairs/ at the Boston Museum of Science, among other places. Thanks also to Amy Woodruff of Splash!Chicago for a long-ago suggestion.

Further reading: https://garden.bradwoods.io/notes/design/juice

willgearty commented 6 months ago

Thanks @pteromys! I like the bounce effect a lot (and it's great that you incorporated the rounding-radius).

While cute, I don't think the piano sound effects are necessary. I'd argue that they should be more of a template override kind of thing.

pteromys commented 6 months ago

Heh, sure, the piano sound effects are merely an Easter egg. Depending on what you think we should support, we could do either of:

Cut them out completely—in which case, we keep only the changes to main.less. An admin would add the sound effects by (1) hosting the js file somewhere and (2) adding the script tag to a template override (...or skip (1) and just paste the whole script inline, though then it'd be part of every page's html).
Just remove the change to main.html—leaving the js file in place so that the hosting step is taken care of. Possibly with comments added to record how to set up the template override.

willgearty commented 6 months ago

Actually, now that I think about it, we're trying to move away from encouraging chapters to make template overrides, since they are a pain to maintain for us (during stable releases) and for them (when admin teams turnover). So, if you really want to encourage/include the functionality, it might be nice to set it up as something that can be enabled/disabled with a global boolean tag (the default would be disabled)? Let me know if you have any questions about how to implement something like that.

willgearty commented 2 months ago

@pteromys just poking you to see if you are still working on this?

pteromys commented 2 months ago

Interested, but no bandwidth for at least two months. Check back in July, if you can stand to let it sit that long?