search

learning-unlimited / ESP-Website

A website to help manage the logistics of large, short-term educational programs
82 stars 57 forks source link

Hiding address_postal field breaks profile form submission #3718

Closed willgearty closed 3 months ago

willgearty commented 4 months ago

The address_postal field is listed as a field that can be hidden in the global tags. However, when this field (or similar fields) is hidden, the form can no longer be submitted/processed. The form processing fails here: https://github.com/learning-unlimited/ESP-Website/blob/7c1ed01bdd65398eda176333ec0d92aa5282f7e2/esp/esp/web/views/myesp.py#L174

We should either make this field required, change how it is handled, or remove it from the list for the tags.

willgearty commented 4 months ago

It looks like this field is only used for the mailing labels module. @milescalabresi suggested deleting this module since no one probably uses it anymore.