learning-unlimited / ESP-Website

A website to help manage the logistics of large, short-term educational programs
84 stars 57 forks source link

New program and program settings forms allow for duplicate program names #3776

Closed willgearty closed 1 month ago

willgearty commented 1 month ago

Despite what this error message says, we only ever check if the URL of the program is the same as any other program, not the name: https://github.com/learning-unlimited/ESP-Website/blob/5c9f4b7cd5c2a9cde528f1edd13bcbc2cf3af078/esp/esp/program/views.py#L618-L623

We don't check either of these things when we are editing a program with the program settings form: https://github.com/learning-unlimited/ESP-Website/blob/5c9f4b7cd5c2a9cde528f1edd13bcbc2cf3af078/esp/esp/program/modules/handlers/admincore.py#L148-L153

Note, at the database level we require unique URLs for programs, so even without the check Django throws an error message.