I realized today that the default min/max grade filters in the USC (added in https://github.com/learning-unlimited/ESP-Website/pull/3424) are in effect for all uses of the USC, not just the comm panel. In doing some testing on my dev server, I tried to get schedules for all students, only to be told that their was no data to render. I realized after the fact that this was because all of the students enrolled in classes were now in grades outside the range of the program (because the program was made in 2017). While not a common edge case for most programs, I do think there are some cases where students outside of the program grade levels are allowed to enroll in a program (this is allowed via the "GradeOverride" permission). If an admin printed all schedules for such a program, these students would be excluded from the printable (and this likely wouldn't be caught until the day of the program).
Therefore, we should probably change the JS to only enable these default grade filters for commpanel instances of the USC. At the minimum, this will save some headache for web dev, and at the maximum it will save a chapter some headache due to missing schedules.
I realized today that the default min/max grade filters in the USC (added in https://github.com/learning-unlimited/ESP-Website/pull/3424) are in effect for all uses of the USC, not just the comm panel. In doing some testing on my dev server, I tried to get schedules for all students, only to be told that their was no data to render. I realized after the fact that this was because all of the students enrolled in classes were now in grades outside the range of the program (because the program was made in 2017). While not a common edge case for most programs, I do think there are some cases where students outside of the program grade levels are allowed to enroll in a program (this is allowed via the "GradeOverride" permission). If an admin printed all schedules for such a program, these students would be excluded from the printable (and this likely wouldn't be caught until the day of the program).
Therefore, we should probably change the JS to only enable these default grade filters for commpanel instances of the USC. At the minimum, this will save some headache for web dev, and at the maximum it will save a chapter some headache due to missing schedules.