learningOrchestra / mlToolKits

learningOrchestra is a distributed Machine Learning integration tool that facilitates and streamlines iterative processes in a Data Science project.
https://learningorchestra.github.io
GNU General Public License v3.0
75 stars 23 forks source link

Refactored docker-compose.yml #88

Closed sudiptog81 closed 4 years ago

sudiptog81 commented 4 years ago

Changes

Refactored duplicate sections in docker-compose.yml to configuration fragments using extension fields.

Fixes and closes #73 .

Type of change

Checklist

sudiptog81 commented 4 years ago

Fixed the discrepancies with "node.role==worker" and "node.role==manager".

Per the newer docker-compose.yml, the diff between the output of docker-compose -f docker-compose.yml config is only the following, mostly due to config version change from 3 to 3.8 which allows extension fields.

25c25,26
<     - 5000:5000/tcp
---
>     - published: 5000
>       target: 5000
67c68,69
<     - 27017:27017/tcp
---
>     - published: 27017
>       target: 27017
113c115,116
<     - 5003:5003/tcp
---
>     - published: 5003
>       target: 5003
136c139,140
<     - 5004:5004/tcp
---
>     - published: 5004
>       target: 5004
149c153,154
<     - 5050:5000/tcp
---
>     - published: 5050
>       target: 5000
179,180c184,187
<     - 5002:5002/tcp
<     - 41100:41100/tcp
---
>     - published: 5002
>       target: 5002
>     - published: 41100
>       target: 41100
208,209c215,218
<     - 5006:5006/tcp
<     - 41300:41300/tcp
---
>     - published: 5006
>       target: 5006
>     - published: 41300
>       target: 41300
239,240c248,251
<     - 5001:5001/tcp
<     - 41000:41000/tcp
---
>     - published: 5001
>       target: 5001
>     - published: 41000
>       target: 41000
258,260c269,274
<     - 4040:4040/tcp
<     - 7077:7077/tcp
<     - 8080:8080/tcp
---
>     - published: 4040
>       target: 4040
>     - published: 7077
>       target: 7077
>     - published: 8080
>       target: 8080
280,281c294,297
<     - 8081:8081/tcp
<     - 41352:41352/tcp
---
>     - published: 8081
>       target: 8081
>     - published: 41352
>       target: 41352
309,310c325,328
<     - 5005:5005/tcp
<     - 41200:41200/tcp
---
>     - published: 5005
>       target: 5005
>     - published: 41200
>       target: 41200
323c341,342
<     - 80:8080/tcp
---
>     - published: 80
>       target: 8080
326c345
< version: '3.0'
---
> version: '3.8'
riibeirogabriel commented 4 years ago

@sudiptog81 Do you have interest in continue contributing with this project? is is the first release yet, more features are coming, and please give a star to help the project, and thanks!

sudiptog81 commented 4 years ago

I wil test this changes in production and then i will merge if everything happens good, okay?

Sure! 😃

@sudiptog81 Do you have interest in continue contributing with this project? is is the first release yet, more features are coming, and please give a star to help the project, and thanks!

Would love to, have some experience working with microservices, and this is an awesome project to collaborate on.