Make the version number in en-minimal '0'

learningequality / ka-lite-content-packs

BSD 2-Clause "Simplified" License

1 stars 6 forks source link

Make the version number in en-minimal '0' #31

Closed benjaoming closed 8 years ago

benjaoming commented 8 years ago

I'm guessing that if we put "language_pack_version": 0 in the metadata of the minimal language pack, then updates will always show up and this issue will be solved?

https://github.com/learningequality/ka-lite/issues/5102

benjaoming commented 8 years ago

It seems that a "code": "en" is absent from all_metadata.json is absent, perhaps if we include English in the content pack meta data, our UI will allow to download updates?

benjaoming commented 8 years ago

Latest json overwritten again. Will fix it manually.

benjaoming commented 8 years ago

@aronasorman my manually edited all_metadata.json have all been overwritten time and time again and I'm kind of tired of manually appending this information.

Would you care to weigh in here?

benjaoming commented 8 years ago

This is the entry that I'm adding....

   {
      "subtitle_count":7208,
      "language_pack_version":3,
      "topic_tree_translated":100,
      "zip_size":733792710,
      "name":"English",
      "beta":false,
      "code":"en",
      "software_version":"0.16",
      "video_count":8034,
      "percent_translated":100,
      "native_name":"English"
   },

benjaoming commented 8 years ago

en-minimal's content data should read "subtitle_count": 0 btw. because it doesn't contain subtitles.. that will make the content pack download page also say +7208 subtitles next to the Upgrade button :)

aronasorman commented 8 years ago

The english data here points to en.zip, not en-minimal.zip. This was previously set to 0 always, causing them not to update their english content pack. But I thought we wanted them to have the option to update? If so, we have to leave it to be incrementing.

benjaoming commented 8 years ago

metadata in en-minimal.zip: Set the version to 0, always, so it always will prompt for an update if installed
en.zip: Use normal versioning
all_metadata: Add en metadata, currently it has none: http://pantry.learningequality.org/downloads/ka-lite/0.16/content/contentpacks/all_metadata.json.bak20160801

benjaoming commented 8 years ago

This issue + the fact that we distribute a broken content pack by default is IMO a great enough reason to simply stop having the minimal content pack.

Instead, for testing purposes, I suggest having something like en-test.zip and making it possible to ship an empty content.db, automatically prompting users to install content packs.