learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Related content should be moved below content area #2586

Closed jamalex closed 10 years ago

jamalex commented 10 years ago

Right now, it distracts users from the main content. Also, there's no need to show the section if there are no related items.

noemigerber commented 10 years ago

Hi @jamalex, I had a more thorough click around, and I still cannot find any related content. Some examples are:

PS: Also, when opening videos I don't see any metadata (description, or organisation). Will that be displayed too?

jamalex commented 10 years ago

Hi @noemigerber! I do see related content on some items, e.g.: http://kitchen.learningequality.org:60130/learn/connectteaching/teaching-and-learning-material/teaching-and-learning-aids/flashcardvegetablesiilores/ (note that I just updated the demo server now, so the flashcards now have titles/related content)

For the two you mention here:

I've opened #2607 regarding metadata on the video player.

jamalex commented 10 years ago

Fixed in #2610.

noemigerber commented 10 years ago

Hi @jamalex, thanks for the update. Yes, I see some related content too - it looks great!! I think it's a really useful feature, so thanks to you and @rtibbles for suggesting it! I hope the users in South Sudan will find it useful too! Thanks also for the update on the metadata, that's very strange. I noticed the following though (in the online demo):

It's very strange that you can't see any metadata for the Teaching Channel 'fill two' resources. I did prepare the metadata for all 5 resources that are related to the "fill two decimal game" video, and the video itself (available on Google Drive). Do you have any idea why this might be?

noemigerber commented 10 years ago

Another thing I wanted to add to the list of questions I sent you @jamalex: @66eli77 mentioned a few days ago via GitHub (in #2486) that he didn't see organisation information in the metadata I sent - which is strange because I've been including it in all metadata files. Could you please let me know where it is missing (do you have a quick way of viewing that?)? Since I've been including it everywhere, I wonder if I've made a mistake in the formatting of the metadata... I'm holding off with creating new metadata files until we work out these issues, since I want to avoid creating new files with mistakes that will later need to be edited. Please do let me know what I can do from my end to work out where these issues are coming from!

66eli77 commented 10 years ago

Hi Noemi I attached the metadata file I'm using with this email for your comparison. I noticed in the videos.json file, not all videos have organization.

Best, Eli

On Fri, Nov 7, 2014 at 7:40 AM, Noemi Gerber notifications@github.com wrote:

Another thing I wanted to add to the list of questions I sent you @jamalex https://github.com/jamalex: @66eli77 https://github.com/66eli77 mentioned a few days ago via GitHub (in #2486 https://github.com/learningequality/ka-lite/issues/2486) that he didn't see organisation information in the metadata I sent - which is strange because I've been including it in all metadata files. Could you please let me know where it is missing (do you have a quick way of viewing that?)? Since I've been including it everywhere, I wonder if I've made a mistake in the formatting of the metadata... I'm holding off with creating new metadata files until we work out these issues, since I want to avoid creating new files with mistakes that will later need to be edited. Please do let me know what I can do from my end to work out where these issues are coming from!

— Reply to this email directly or view it on GitHub https://github.com/learningequality/ka-lite/issues/2586#issuecomment-62162722 .

rtibbles commented 10 years ago

@66eli77 Won't appear on github, unfortunately. I think we need to take a look at the files that @noemigerber has been making on Google Drive to determine what's going on here.

rtibbles commented 10 years ago

@noemigerber A preliminary look from me, seems to suggest you are making the metadata correctly. I will be checking into the content importing later today to see what the issue is here.

noemigerber commented 10 years ago

Hi @rtibbles and @66eli77, thanks so much for looking into the metadata issues. It's good to read in #2641 that you seem to have located the problem. Thanks also for letting me know that it looks as though I'm making the metadata correctly. In that case I'll continue making more metadata files and update Google Drive as I go!