search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Accessibility Issue - custom button opening the sidebar menu cannot be activated with keyboard #3346

Open nate-getch opened 9 years ago

nate-getch commented 9 years ago

Branch – Develop Expected behavior – All buttons should be focusable and has to handle keyboard events in order to be usable by both keyboard only users and users using screen reader. Current behavior – Custom button on the left opening the sidebar menu cannot be activated with keyboard.

Screen readers cannot identify generic divs or spans as controls. And divs or spans aren’t focusable, so they cannot be activated with keyboard by default.

MCGallaspy commented 9 years ago

Is this too ambitious for 0.14?

rtibbles commented 9 years ago

Given that @radinamatic will be implementing most of this, and her GSoC term does not start until June, I would say, yes.

radinamatic commented 9 years ago

Unless my coding skills get waaaay better in a matter of days by some KA Lite's own miracle, yeah, I'd say it's too ambitious... ;)

rtibbles commented 9 years ago

I assume this will require the addition of text to describe the button for screen readers. Punting.

radinamatic commented 7 years ago

I could only wish this is the sole keyboard navigation issue KA Lite had... :sob:

benjaoming commented 7 years ago

Opening and navigating the menus is working fine with arrow navigation on Chrome.