search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Contentpack errors on 0.17.0b2 #5336

Closed radinamatic closed 7 years ago

radinamatic commented 7 years ago

Summary

Some contentpack errors on 0.17 beta release.

System information

Screenshots

Alert to update language pack right after installation, so far so good...

0 17-cps1

But no way to update once Admin is on Languages page:

0 17-cps2

Also, Delete button is a bit misnomer here: why would somebody delete the only contentpack/language installed...?

Installed other languages, they all present the alert to update at login, but result apparently "Up-to-date":

0 17-cps6

0 17-cps5

No pt-PT contentpack that I did see yesterday after installing 0.16.9 on Windows XP:

0 17-cps3

Swahili, Zulu & Xhosa language packs have no available videos for download, and load an empty topic tree in the sidebar:

0 17-cps4

No available subtitles anywhere!!!

Not sure if this should go in the separate issue?

benjaoming commented 7 years ago

Regarding the delete button, please see #5232 and #5318

benjaoming commented 7 years ago

All of the content packs are just copied raw from 0.16, I think (but haven't investigated) that this is somehow related, i.e. the old version tag in the JSON metadata prompts the UI javascript to assume an upgrade is available.

benjaoming commented 7 years ago

...but we should start building new content packs for 0.17 testing, this could be done as soon as we ensure the current state of things.. I don't feel too on top of the latest content pack updates for various language bugs and whether they are done. But we could also decide to move all efforts to 0.17 language packs.

radinamatic commented 7 years ago

@mrpau-eduard @mrpau-richard What say you?

mrpau-richard commented 7 years ago

I think we need to build all the language packs and update its version to 0.17.

benjaoming commented 7 years ago

@mrpau-richard build? which languages are you talking about here?

Because of many issues, we've decided to not build any new versions of content packs that are already working.. it seems fine to copy them straight from 0.16, but please do say if there are any issues?

mrpau-richard commented 7 years ago

@benjaoming Yeah, I agree as we discuss in our last syncup.

radinamatic commented 7 years ago

macOS Sierra, today's OSX installer by @mrpau-richard.

Ok, so upgrading English language, weather from the Terminal or UI, does not register or reflect correctly in Manage > Languages, meaning the button does not change to Up to date once the upgrade is finished, and the prompt/alert is still visible on the homepage.

After upgrading from the Terminal, refreshing, re-logging-in and restarting the server:

virtualbox_sierra_01_12_2016_14_20_08

After re-trying the upgrade from UI and reloading:

virtualbox_sierra_01_12_2016_14_47_07

Admin is still prompted to upgrade:

virtualbox_sierra_01_12_2016_14_50_10

@benjaoming If this is not a contentpack error, I'll file it as a separate issue.

radinamatic commented 7 years ago

Confirmed with the Spanish contentpack install, after downloading, upgrading and restarting the server, the button still says Upgrade:

virtualbox_sierra_01_12_2016_15_10_37

benjaoming commented 7 years ago

Closing this, as stated the "Upgrade" buttons are supposed to be displayed because our testing data for 0.17 content packs have correctly been equipped with a meta data saying they are from 0.16...which they are :)

radinamatic commented 7 years ago

Ok, will re-test this with the new contentpacks!