Video-js and VTT.js upgrade

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity

https://learningequality.org/ka-lite/

Other

458 stars 305 forks source link

Video-js and VTT.js upgrade #5349

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

Fixes #5347

It became a bit of an assorted fixes and improvements PR, so here's an overview:

Makes srt serving work with DEBUG=True and runserver
Removed the minimal content pack fetching from assets make target.
Added minimal content pack as a sort of test data content pack, we should rebuild a much smaller one though
Removed unused and unmaintained .travis.yml

codecov-io commented 7 years ago

Current coverage is 51.02% (diff: 66.66%)

Merging #5349 into develop will decrease coverage by 0.06%

@@            develop      #5349   diff @@
==========================================
  Files           142        142          
  Lines          7482       7485     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           3822       3819     -3   
- Misses         3660       3666     +6   
  Partials          0          0

Powered by Codecov. Last update 2892094...d41f9e6

benjaoming commented 7 years ago

Interestingly, this PR starts work on removing the minimal English content pack so also addresses #5318

benjaoming commented 7 years ago

On another note, the current patched git forks of video.js + vtt.js require the build systems to be able to fetch stuff in package.json with git -- no problem on Linux, but could cause issues on Mac / Windows build systems.. I can fix this if necessary @mrpau-eduard @mrpau-richard so let me know if make assets or npm install fails in your installer scripts after this merge.