Closed benjaoming closed 7 years ago
@@ develop #5350 diff @@
==========================================
Files 142 142
Lines 7487 7608 +121
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3820 3942 +122
+ Misses 3667 3666 -1
Partials 0 0
Powered by Codecov. Last update 0969659...b89c622
All BDD tests are actually working now, other tests are failing because they haven't got a content.db with fixtures.
Update on English content pack vs. empty content.db:
If there is an empty content.db (i.e. no content packs installed), the user will now be displayed this warning regardless of the situation. For instance, if you have 1 other language, it will still show up. I think this is the intention of all content packs as they do not contain any static exercise data files.
Summary
We should finally kill off the English content pack, as the only purpose it serves is to have a function content tree in a blank installation -- for which users should download a full English content pack, anyways.
This will also greatly improve test speeds AFAIK.
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
<a>
elements, make surecursor:pointer
is restored~ Restored because of accessibility concerns, @radinamatic look, you didn't even have to point it out :)Reviewer guidance
Please comment if you have any concerns about testing with no content data :) IMO we need to speed up the tests significantly, so going from 92MB test db to ~0 MB is pretty awesome.
Issues addressed
5336 #5318