learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Add space because of character issue in Swahili translation #5381

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

supersedes #5378

fixes #5323

codecov-io commented 7 years ago

Current coverage is 51.46% (diff: 100%)

Merging #5381 into develop will not change coverage

@@            develop      #5381   diff @@
==========================================
  Files           143        143          
  Lines          7553       7553          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3887       3887          
  Misses         3666       3666          
  Partials          0          0          

Powered by Codecov. Last update 2aa0270...e1c7cea

mrpau-eduard commented 7 years ago

Hi @benjaoming thanks for helping! I check the video dowload for Swahili. The issue is still persisting. screen shot 2017-01-09 at 5 28 08 pm

benjaoming commented 7 years ago

Thanks for testing @mrpau-eduard - wondering why adding the space outside gettext() would cause it to persist? You had tested that adding a blank space " " fixed it, no?

benjaoming commented 7 years ago

@mrpau-eduard - can you take this over? I'm closing it because you found possible issues.. but the current Swahili translation is this:

Maendeleo yaliyokidhiri:%(percent_complete)5.1%%kamilika%(cur_stage)d ya%(num_stages)d

English is:

Overall progress: %(percent_complete)5.1f%% complete (%(cur_stage)d of %(num_stages)d)

As I read it, the problem is in the translation string, not something that should be fixed in the code?

benjaoming commented 7 years ago

@mrpau-eduard

I have updated and approved the string in this state:

Maendeleo yaliyokidhiri: %(percent_complete)5.1%% kamilika (%(cur_stage)d ya %(num_stages)d)

Try rebuilding the content pack and see if it works now?