Closed benjaoming closed 7 years ago
@@ develop #5386 diff @@
==========================================
Files 143 143
Lines 7516 7491 -25
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 3884 3882 -2
+ Misses 3632 3609 -23
Partials 0 0
Powered by Codecov. Last update 4aa06af...2d1ea12
Alright, seems it was just a matter of moving srt/
from STATIC_ROOT
to CONTENT_ROOT
in the unpacking process and then the annotation process.
Since the .srt
files are now handled in CONTENT_ROOT
, there's no need to update the folders served by the dev server, cherrypy or Nginx. Users having setup other mechanisms for serving these folders will also not be affected. This is great :)
Tested after reinstalling the English content pack that subtitles are still working
Summary
kalite manage contentpackchecker all --update
so it only updates installed content packs*.vtt
toCONTENT_ROOT/srt
: Annotates with updated url and no longer needs to ignore any file or folder patterns duringcollectstatic
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
get_subtitle_file_path
/perseus/ke/exercises/*
kalite.management.commands.setup
, removecollectstatic_ignores
url
columnrunserver
Reviewer guidance
Let me know if you find anything unacceptable here. New static files handing will be described in release notes.
Issues addressed
5073