learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
457 stars 304 forks source link

Remove artifacts from dependency links #5391

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Dependency links are not support in Pip 9, which is already released. But we haven't needed them since #5319 was solved.

codecov-io commented 7 years ago

Current coverage is 51.82% (diff: 100%)

Merging #5391 into develop will not change coverage

@@            develop      #5391   diff @@
==========================================
  Files           143        143          
  Lines          7491       7491          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3882       3882          
  Misses         3609       3609          
  Partials          0          0          

Powered by Codecov. Last update 77930c4...18d3af8

benjaoming commented 7 years ago

This should be safe to merge - if it causes issues, they will show up during building of installers, however since Pip 9 is already out, it's also quite critical to get rid of this deprecated call.

radinamatic commented 7 years ago

Tested the pip install this morning, all's well! 👍

virtualbox_ubuntu 16 10_23_01_2017_14_39_00

virtualbox_ubuntu 16 10_23_01_2017_14_41_52