learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
457 stars 304 forks source link

Add traceback to error 500 page #5405

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

Due to various issues reported, I'm trying to affirm that device registration works through a bit of fumbling.

Issues addressed

5401

5123

codecov-io commented 7 years ago

Codecov Report

Merging #5405 into 0.17.x will increase coverage by 0.04%.

@@            Coverage Diff            @@
##           0.17.x   #5405      +/-   ##
=========================================
+ Coverage   51.76%   51.8%   +0.04%     
=========================================
  Files         143     143              
  Lines        7499    7499              
=========================================
+ Hits         3882    3885       +3     
+ Misses       3617    3614       -3
Impacted Files Coverage Δ
kalite/distributed/views.py 61.14% <ø> (+1.91%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 019139e...34b91fa. Read the comment docs.

benjaoming commented 7 years ago

New error page (before clicking textarea)

screenshot from 2017-02-10 20-29-44

After clicking text area:

screenshot from 2017-02-10 20-30-23

radinamatic commented 7 years ago

:heart_eyes:

benjaoming commented 7 years ago

Merging this, because then at least we can know about the other issue on Mac/Windows that we haven't been able to troubleshoot through logs etc.