benjaoming commented 7 years ago

Sorry about that @mrpau-eduard @mrpau-richard

I was rushing along in some kind of fantasy world where we had test cases for pages like the registration page.

facepalm

codecov-io commented 7 years ago

Codecov Report

Merging #5406 into 0.17.x will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           0.17.x   #5406      +/-   ##
=========================================
+ Coverage   51.76%   51.8%   +0.04%     
=========================================
  Files         143     143              
  Lines        7499    7499              
=========================================
+ Hits         3882    3885       +3     
+ Misses       3617    3614       -3

Impacted Files	Coverage Δ
...ite/distributed/features/steps/superuser_create.py	`95.52% <100%> (ø)`	:white_check_mark:
kalite/distributed/views.py	`61.14% <ø> (+1.91%)`	:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1649a6...b617aa0. Read the comment docs.

benjaoming commented 7 years ago

@radinamatic did you report suspicion that am_i_online is unstable?

At least, the latest test failure seems to support the claim:

======================================================================
FAIL: test_online (kalite.updates.tests.regression_tests.RegistrationRedirectTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/ka-lite/kalite/updates/tests/regression_tests.py", line 28, in test_online
    self.assertEqual(am_i_online(), google_is_online)
AssertionError: False != True

The above test has worked every time since the change was made, now fails...

learningequality / ka-lite

Remove debug exception expression, + test case #5406

Codecov Report