search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
457 stars 304 forks source link

prevent underneath body element from scrolling when scroll the sideba… #5410

Closed 66eli77 closed 7 years ago

66eli77 commented 7 years ago

…r or sidebar-fade area

Summary

Fix the issue #5407 Only tested on Mac chrome and android chrome browsers, would need more testing on different devices, especially on Linux where the issue is originally discovered.

TODO

66eli77 commented 7 years ago

A separate issue, seems clicking on sidebar item not working on IE9. @benjaoming is kalite 0.17 supposed to support IE9?

codecov-io commented 7 years ago

Codecov Report

Merging #5410 into 0.17.x will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.17.x    #5410   +/-   ##
=======================================
  Coverage   51.76%   51.76%           
=======================================
  Files         143      143           
  Lines        7499     7499           
=======================================
  Hits         3882     3882           
  Misses       3617     3617

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e030914...0c9bf72. Read the comment docs.

benjaoming commented 7 years ago

@66eli77 yes, we do :)

http://ka-lite.readthedocs.io/en/latest/installguide/system_requirements.html

benjaoming commented 7 years ago

It sounds like from @nedrichards that it's been tested for Edge, so I've marked it as Done.

Merging now, this will be part of the 0.17.1 release.