learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity

https://learningequality.org/ka-lite/

Other

457 stars 304 forks source link

Update rsa - fixes #5401 #5411

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

Wondering if the 0.16 series is also broken. Tests so far indicate that it should be, or perhaps it's related to Python 2.7.12. We don't really know yet...

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

[x] Have tests been written for the new code? If you're fixing a bug, write a regression test (or have a really good reason for not writing one... and I mean really good!)
[x] Has documentation been written/updated?
[x] New dependencies (if any) added to requirements file

Reviewer guidance

I'll test this on Ubuntu 16.04, I think that changes in rsa look fairly conservative and safe.

Issues addressed

5401

Screenshots (if appropriate)

They're nice. :)

codecov-io commented 7 years ago

Codecov Report

Merging #5411 into 0.17.x will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.17.x    #5411   +/-   ##
=======================================
  Coverage   51.76%   51.76%           
=======================================
  Files         143      143           
  Lines        7499     7499           
=======================================
  Hits         3882     3882           
  Misses       3617     3617

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e030914...5ae1a6c. Read the comment docs.

benjaoming commented 7 years ago

@jamalex merging this for further building and testing, please jump in with hindsight if you spot anything in the new version of rsa